Add NavigateEvent.sourceElement#10898
Merged
domenic merged 4 commits intowhatwg:mainfrom Jan 28, 2025
Merged
Conversation
The `sourceElement` of the `navigate` event is either the clicked link, the submitter button, or the submitted form if there was no submitter button. See https://github.com/WICG/navigation-api?tab=readme-ov-file#navigation-monitoring-and-interception
annevk
reviewed
Jan 7, 2025
Member
|
cc @rwlbuis |
domenic
approved these changes
Jan 15, 2025
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
Beautiful! I'm thankful we didn't have to thread this through too many layers 😅
Member
I think we should revert web-platform-tests/wpt#46072 too |
Collaborator
Author
All the checkboxes are ticked. Merge? |
Member
|
Do you have a tests PR for reverting web-platform-tests/wpt#46072 ? |
Collaborator
Author
|
domenic
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jan 28, 2025
This reverts commit 6c91fbc (#46072) as part of whatwg/html#10898.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 29, 2025
…eElement", a=testonly Automatic update from web-platform-tests Revert "Check use of NavigateEvent.sourceElement (#46072)" (#50329) This reverts commit 6c91fbce8312c431a1e0a6db5d001438f96531e9 (#46072) as part of whatwg/html#10898. -- wpt-commits: 765e5eec7bda0828ba73b3b0d28a7d661eeceb17 wpt-pr: 50329
This was referenced Jan 30, 2025
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Jan 30, 2025
Corresponds to whatwg/html#10898 This is with whatwg/html#10971 also applied - the original PR missed `sourceElement` from the `NavigateEventInit` dictionary. I've also updated the imported WPT test as it's been recently changed to account for 10898 being merged.
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Jan 31, 2025
Corresponds to: - whatwg/html#10898 - whatwg/html#10971 I've also updated the imported WPT test as it's been recently changed to account for 10898 being merged.
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Feb 3, 2025
Corresponds to: - whatwg/html#10898 - whatwg/html#10971 I've also updated the imported WPT test as it's been recently changed to account for 10898 being merged.
awesomekling
pushed a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Feb 4, 2025
Corresponds to: - whatwg/html#10898 - whatwg/html#10971 I've also updated the imported WPT test as it's been recently changed to account for 10898 being merged.
jcsteh
pushed a commit
to jcsteh/firefox
that referenced
this pull request
May 1, 2025
…eElement", a=testonly Automatic update from web-platform-tests Revert "Check use of NavigateEvent.sourceElement (#46072)" (#50329) This reverts commit 6c91fbce8312c431a1e0a6db5d001438f96531e9 (#46072) as part of whatwg/html#10898. -- wpt-commits: 765e5eec7bda0828ba73b3b0d28a7d661eeceb17 wpt-pr: 50329
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sourceElementof thenavigateevent is either the clicked link, the submitter button, or the submitted form if there was no submitter button.See https://github.com/WICG/navigation-api?tab=readme-ov-file#navigation-monitoring-and-interception
sourceElementmozilla/standards-positions#1154sourceElementWebKit/standards-positions#441(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/form-control-infrastructure.html ( diff )
/links.html ( diff )
/nav-history-apis.html ( diff )